clang static analysis updated with tinderbox

[Jeremy Huddleston]

On Apr 29, 2011, at 1:35 AM, Dirk Wallenstein wrote:

>> --- a/jhbuild/modtypes/autotools.py
>> +++ b/jhbuild/modtypes/autotools.py
>> @@ -121,13 +121,14 @@ class AutogenModule(Package, DownloadableModule):
>>         if self.autogen_template:
>>             template = self.autogen_template
> If this is configured, %(scan_build) won't be added. Would it make sense
> to add it independently, after this branching?

I would expect that %(scan_build) would be provided in self.autogen_template in the modules xml file if it was desired.  Is that not custom?  I'm not really sure what should take precedence here.

>> +    def scan_build_template(self, buildscript):
>> +        if self.name in buildscript.config.module_scan_build or buildscript.config.scan_build:
> I would say the module specific setting should override the global one,
> something like:
> 
>    if buildscript.config.module_scan_build.get(self.name, buildscript.config.scan_build):

Great, thanks.