[PULL] Accumulated small input changes
Chase Douglas
chase.douglas at canonical.com
Fri Apr 29 06:35:03 PDT 2011
On 04/29/2011 08:33 AM, Daniel Stone wrote:
> On Thu, Apr 28, 2011 at 02:00:10PM -0700, Keith Packard wrote:
>> On Thu, 28 Apr 2011 17:43:05 +0100, Daniel Stone <daniel at fooishbar.org> wrote:
>>> Sure, I've made it an inline function now, but removed Peter's R-b. Do
>>> you (or anyone else) want to review it? :)
>>
>> Looks fairly reasonable, the only comment is that if spriteTraceGood is
>> zero, we've got serious issues, so perhaps an assert rather than a
>> return NULL?
>
> Ah yes, you're right; forgot about the root window always being present.
> I've updated my tree now, but that commit is still lacking any R-b tag.
I've checked it out here:
http://cgit.freedesktop.org/~daniels/xserver/commit/?h=for-keith&id=628c5854e15dbc4c57a01286a721e9fa8cf809e9
You can add:
Reviewed-by: Chase Douglas <chase.douglas at canonical.com>
Thanks,
-- Chase
More information about the xorg-devel
mailing list