[PATCH:macros 2/2] Make XORG_STRICT_OPTION always set STRICT_CFLAGS

Gaetan Nadon memsize at videotron.ca
Thu Apr 28 18:10:17 PDT 2011


On Wed, 2011-04-27 at 19:13 -0700, Dan Nicholson wrote:

> On Wed, Apr 27, 2011 at 5:32 PM, Alan Coopersmith
> <alan.coopersmith at oracle.com> wrote:
> > On 04/27/11 03:54 AM, Dan Nicholson wrote:
> >> IMO, you should at least AC_SUBST the variable if you want to use it
> >> somewhere else.
> >
> > I just wanted to make it available to the XORG_TLS macro Jeremy's working
> > on, not in a Makefile - is AC_SUBST needed for that?
> >
> > On the other hand it doesn't hurt, so I can easily add it anyway.
> 
> My thinking is that it's odd to depend on an internal variable of
> another macro. AC_SUBST doesn't change anything, but at least it's
> being announced. I'm just being pedantic, though.
> 

I agree. By virtue of usage, AC_SUBST has acquired a "public"
declaration role.
The value is stored in config.status and config.log which helps
debugging.



> --
> Dan
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110428/435703a0/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110428/435703a0/attachment.pgp>


More information about the xorg-devel mailing list