[PATCH] dix: only transform valuators when we need them.

Daniel Stone daniel at fooishbar.org
Thu Apr 28 04:27:12 PDT 2011


On Mon, Apr 25, 2011 at 12:58:17PM -0400, Chase Douglas wrote:
> Why don't we change this to:
> 
> if (lround(p.v[0]) != dev->last.valuators[0])
>     valuator_mask_set(mask, 0, lround(p.v[0]));
> else
>     valuator_mask_unset(mask, 0);
> 
> The proposed fix will cause valuators to be sent with repeated values if
> they haven't actually changed.

Good catch.  With or without this change:
Reviewed-by: Daniel Stone <daniel at fooishbar.org>

(Peter, I haven't picked this one up -- up to you to decide what to do.)

Cheers,
Daniel


More information about the xorg-devel mailing list