[PATCH iceauth] Error out and avoid a call to malloc(0) if given a bad hex string

Jeremy Huddleston jeremyhu at apple.com
Thu Apr 28 00:53:17 PDT 2011


Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>
---
 process.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/process.c b/process.c
index f51e643..56b7aaf 100644
--- a/process.c
+++ b/process.c
@@ -401,8 +401,8 @@ static int cvthexkey (	/* turn hex key string into octets */
 	len++;
     }
 
-    /* if odd then there was an error */
-    if ((len & 1) == 1) return -1;
+    /* if 0 or odd, then there was an error */
+    if (len == 0 || (len & 1) == 1) return -1;
 
 
     /* now we know that the input is good */
-- 
1.7.4.1




More information about the xorg-devel mailing list