[PATCH 2/5] Xext: Silence warnings when building with clang

Jamey Sharp jamey at minilop.net
Sun Apr 24 22:19:09 PDT 2011


Looks like an improvement, warnings or not.

Reviewed-by: Jamey Sharp <jamey at minilop.net>

On Sat, Apr 23, 2011 at 09:52:29PM -0700, Jeremy Huddleston wrote:
> xvmain.c:1113:22: warning: equality comparison with extraneous parentheses [-Wparentheses]
>       if ((pf->depth == pDraw->depth)
>            ~~~~~~~~~~^~~~~~~~~~~~~~~
> xvmain.c:1113:22: note: use '=' to turn this equality comparison into an assignment
>       if ((pf->depth == pDraw->depth)
>                      ^~
>                      =
> xvmain.c:1113:22: note: remove extraneous parentheses around the comparison to silence this warning
>       if ((pf->depth == pDraw->depth)
>           ~          ^              ~
> 1 warning generated.
> 
> Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>
> ---
>  Xext/xvmain.c |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
> 
> diff --git a/Xext/xvmain.c b/Xext/xvmain.c
> index cd6f097..d21a56c 100644
> --- a/Xext/xvmain.c
> +++ b/Xext/xvmain.c
> @@ -1110,12 +1110,7 @@ XvdiMatchPort(
>  
>    while (nf--)
>      {
> -      if ((pf->depth == pDraw->depth) 
> -#if 0
> -         && ((pDraw->type == DRAWABLE_PIXMAP) || 
> -	   (wVisual(((WindowPtr)pDraw)) == pf->visual))
> -#endif
> -	)
> +      if (pf->depth == pDraw->depth)
>  	return Success;
>        pf++;
>      }
> -- 
> 1.7.4.1
> 
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110424/e6f78d9e/attachment.pgp>


More information about the xorg-devel mailing list