[PATCH 1/4] savage: Fix logic in waitHSync
Tormod Volden
lists.tormod at gmail.com
Wed Apr 20 13:09:49 PDT 2011
From: Tormod Volden <debian.tormod at gmail.com>
Bit-masking the result of a boolean negation seems pointless,
so I guess this is what was intended: Only look at bit 0 of the
inStatus result.
Signed-off-by: Tormod Volden <debian.tormod at gmail.com>
---
Hi,
A few savage patches. Review is appreciated.
This one is similar to 3f18b334812086e5f487a4570a34a3906a67724c
"savage: Fix ambiguity in SavageLoadPaletteSavage4".
Probably not a very critical fix, but does not seem to break
anything either. I guess there can be a small timing difference,
as it now will wait (as intended) for the whole pulse.
I have gone through the output of git grep '!.* & ' so this
should be the last of this kind.
src/savage_cursor.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/savage_cursor.c b/src/savage_cursor.c
index 4d193eb..6364293 100644
--- a/src/savage_cursor.c
+++ b/src/savage_cursor.c
@@ -67,8 +67,8 @@ static void SavageSetCursorColors(ScrnInfoPtr pScrn, int bg, int fg);
#define waitHSync(n) { \
int num = n; \
while (num--) { \
- while ((inStatus1()) & 0x01){};\
- while (!(inStatus1()) & 0x01){};\
+ while (inStatus1() & 0x01){};\
+ while (!(inStatus1() & 0x01)){};\
} \
}
#define MAX_CURS 64
--
1.7.0.4
More information about the xorg-devel
mailing list