[PATCH v3 1/6] composite: Call ValidateGC after ChangeGC

ville.syrjala at nokia.com ville.syrjala at nokia.com
Fri Apr 15 11:42:09 PDT 2011


From: Ville Syrjälä <ville.syrjala at nokia.com>

ChangeGC changes the GC, so ValidateGC should be called after it, not
before.

Signed-off-by: Ville Syrjälä <ville.syrjala at nokia.com>
Reviewed-by: Keith Packard <keithp at keithp.com>
Reviewed-by: Adam Jackson <ajax at redhat.com>
Reviewed-by: Daniel Stone <daniel at fooishbar.org>
---
v3: unchanged

 composite/compalloc.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/composite/compalloc.c b/composite/compalloc.c
index e4064f6..e840ee8 100644
--- a/composite/compalloc.c
+++ b/composite/compalloc.c
@@ -562,9 +562,8 @@ compNewPixmap (WindowPtr pWin, int x, int y, int w, int h, Bool map)
 	{
 	    ChangeGCVal val;
 	    val.val = IncludeInferiors;
-	    
+	    ChangeGC (NullClient, pGC, GCSubwindowMode, &val);
 	    ValidateGC(&pPixmap->drawable, pGC);
-	    ChangeGC (serverClient, pGC, GCSubwindowMode, &val);
 	    (*pGC->ops->CopyArea) (&pParent->drawable,
 				   &pPixmap->drawable,
 				   pGC,
-- 
1.7.3.4



More information about the xorg-devel mailing list