[PATCH 0/3] XWin: Find GL specs, rather than downloading them
Ian Romanick
idr at freedesktop.org
Thu Apr 14 12:25:13 PDT 2011
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 04/14/2011 05:46 AM, Jon TURNEY wrote:
> On 05/01/2011 20:30, Jon TURNEY wrote:
>> On 05/01/2011 14:25, Daniel Stone wrote:
>>> Previously the XWin build required a live internet connection (and
>>> Khronos's servers to not be down for maintenance, etc) in order to
>>> download the (W)GL specs to autogenerate files from. Even if you
>>> weren't building XWin, this broke distcheck.
>>
>> Yes, this is pretty bad atm. I'm not sure why I did things this way in the
>> first place. I think perhaps I was concerned about that I didn't know the
>> license terms for those files and didn't want to get stuck with manually
>> updating them.
>>
>> Perhaps it would be better to simply remove these files, and I should just
>> create a package for cygwin containing these files, and then make that a
>> build-time requirement?
>
> Yet another attempt at resolving this issue.
>
> I was hoping to use the mesa XML specifications, and did write the python
> changes to use an XML parser, but mesa doesn't contain an XML description
> of the WGL interface, and I don't want to make one, so this continues to
> use the .spec/.tm files, but now looks for them via pkg-config or in a
> directory specified by a new configure option.
>
> The names of things could probably be chosen more carefully, and I'm not
> sure if or how to indicate that the new configure option has no effect
> unless you are building XWin.
>
> This patch-set also includes my patch [1], as it doesn't make much sense
> to have this mechanism in ./configure until --enable-aiglx actually works
> for XWin.
>
> [1] http://patchwork.freedesktop.org/patch/376/
>
> Jon TURNEY (3):
> configure: Let configure --enable/disable-aiglx control building of
> AIGLX for all DDXs
> configure: Look for Khronos OpenGL spec files using pkg-config
> hw/xwin: wglext.h should be provided by w32api, rather than
> downloaded
>
> configure.ac | 25 ++++++++++++++++++++-----
> glx/Makefile.am | 2 +-
> hw/xfree86/dixmods/Makefile.am | 2 +-
> hw/xwin/glx/.gitignore | 7 +------
> hw/xwin/glx/Makefile.am | 32 ++++++--------------------------
> hw/xwin/glx/wgl_ext_api.c | 2 +-
> hw/xwin/glx/wgl_ext_api.h | 2 +-
> 7 files changed, 31 insertions(+), 41 deletions(-)
>
This seems like the right way to do this. It looks like 1/3 will
conflict with Adam's "[PATCH 2/2] glx: Make --disable-dri not disable
AIGLX".
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAk2nShkACgkQX1gOwKyEAw9C4QCffDLzqD6sKoT9KPQFUQaOW0zs
MUgAn0x0M1KVyoZ1m/EtkpQB3IakYZlN
=3G3P
-----END PGP SIGNATURE-----
More information about the xorg-devel
mailing list