[PATCH] Xi: fix valuator alignment in DeepCopyDeviceClasses (#36119)

[Daniel Stone]

Hi,

On Thu, Apr 14, 2011 at 12:31:00PM +1000, Peter Hutterer wrote:
> On Tue, Apr 12, 2011 at 09:58:57AM +0100, Daniel Stone wrote:
> > On Tue, Apr 12, 2011 at 11:05:56AM +1000, Peter Hutterer wrote:
> > > +    /* force alignment with double */
> > > +    union align_u { ValuatorClassRec valc; double d; } *align;
> > 
> > Errr ... why not just allocate valc->axes separately from valc?
> 
> mostly because this is the second half to Keith's patch
> 678f5396c91b3d0c7572ed579b0a4fb62b2b4655 and I'd rather have this in one
> location before I start changing the layout again. I don't know how many
> other places there are that rely on this to be one memory block.
> 
> It's a quickfix for a specific issue that'll hopefully become obsolete with
> the next input ABI.

OK.  In that case:
Acked-by: Daniel Stone <daniel at fooishbar.org>

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110414/50862dcc/attachment.pgp>