[PATCH XTS 0/2] Fix 'missing sentinel in function call' warnings

Aaron Plattner aplattner at nvidia.com
Tue Apr 12 17:28:35 PDT 2011


Fixing this set of GCC warnings turned out to be a little involved, so I
split it into two.  I'm not convinced that this is totally appropriate,
since what XTS was doing ought to be valid.  Basically, the problem is that
it does this:

  char *sentinel = NULL;
  function(..., sentinel);

and GCC complains about that.  Part of the reason it does that is that some
of the calls are generated by mc, which looks at the list of arguments
specified at the top of the file, for which it also generates declarations
and initalizers.  Adding the ability to pass literal NULLs through required
modifying mc.


Aaron Plattner (2):
  mc: Add the ability to pass literal NULL arguments to XCALL functions
  xts5: Fix 'missing sentinel in function call' warnings by using
    literal NULL

 xts5/Xlib14/XGetICValues.m        |    2 +-
 xts5/Xlib14/XGetIMValues.m        |    2 +-
 xts5/Xlib14/XSetICFocus.m         |    2 +-
 xts5/Xlib14/XSetICValues.m        |   28 ++++++++++++++--------------
 xts5/Xlib14/XVaCreateNestedList.m |   35 ++++++++++++++++-------------------
 xts5/src/bin/mc/code.c            |    8 ++++++++
 xts5/src/bin/mc/mc.h              |    1 +
 7 files changed, 42 insertions(+), 36 deletions(-)



More information about the xorg-devel mailing list