[PATCH] [RFC] dix/mi: remove ChangeWindowAttributes from rendering path.

Aaron Plattner aplattner at nvidia.com
Mon Apr 4 08:16:12 PDT 2011


On Wed, Mar 30, 2011 at 11:07:46PM -0700, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> This moves ChangeWindowAttributes to mi, and calls a new hook
> that fb/exa can use to fixup the pixmap properly.
> 
> I've looked at XAA and it seems this should work there as well,
> and I'm sure UXA is like EXA.
> 
> pretty much same set of open questions:
> 
> sane? interface good enough? naming?
> 
> (again only lightly tested with emacs which hits these
> paths inside Xcan't spell it.
> 
> Dave.
> ---
> diff --git a/mi/miscrinit.c b/mi/miscrinit.c
> index 348309e..dd9aafe 100644
> --- a/mi/miscrinit.c
> +++ b/mi/miscrinit.c
> @@ -253,6 +253,7 @@ miScreenInit(
>      pScreen->PostValidateTree = (PostValidateTreeProcPtr) 0;
>      pScreen->WindowExposures = miWindowExposures;
>      pScreen->CopyWindow = miCopyWindow;
> +    pScreen->ChangeWindowAttributes = miChangeWindowAttributes;
>      /* CopyWindow */
>      pScreen->ClearToBackground = miClearToBackground;
>      pScreen->ClipNotify = (ClipNotifyProcPtr) 0;

Are you planning on leaving the ChangeWindowAttrbutes screen hook there, or
is it slated for deletion?  I ask because we currently wrap CWA so we can
watch for colormap changes on PseduoColor windows.

-- Aaron


More information about the xorg-devel mailing list