[PATCH] xclipboard: Change resource to better position Accept/Cancel. #17364

[Dan Nicholson]

On Sun, Apr 3, 2011 at 3:22 AM, Alistair Leslie-Hughes
<leslie_alistair at hotmail.com> wrote:
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=17364
>
> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>

A couple comments.

1. Even though the bug report has the essential information, it would
be nice if the commit message explained why this change does anything
useful. For your other patch, it's was pretty clear what the issue was
from the subject, but this one isn't too clear.

2. Following through to the debian bug, it seems that Stanislav came
up with this fix. If that's true, I think you would want to make him
the author of this patch or at least credit him in the commit message.
Furthermore, your patch is slightly different than his, but doesn't
explain why.

http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=24;filename=xclipboard-file-dialog-patch.diff;att=1;bug=127060

--
Dan