[PATCH libpciaccess] config: provide a makefile for scanpci dev tool

Mark Kettenis mark.kettenis at xs4all.nl
Sat Sep 25 08:44:07 PDT 2010


> Date: Wed, 22 Sep 2010 16:45:37 +0300
> From: Tiago Vignatti <tiago.vignatti at nokia.com>
> 
> On Tue, Sep 21, 2010 at 07:09:45PM +0200, ext Gaetan Nadon wrote:
> > No function changes.
> > 
> > Note that automake generates a wrapper script if libpciaccess
> > is not installed at configuration time, which is the most common case.
> > 
> > If it is installed at configuration time, you get an executable.
> > 
> > The makefile build order ensures the lib is build before scanpci.
> > 
> > The man page is moved to the man directory, as usual.
> > 
> > Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> 
> I think your changes are nice, but I'd prefer to see those split up
> in two patches instead: one to remove the wrapper script, using a
> proper makefile and another to move code around, creating scanpci/
> directory and man/

What's the point?  Is there really a chance you want to backout a
single one of the three diffs you suggest?


More information about the xorg-devel mailing list