[PATCH modular] Implement a classification for scripts using subdirectories

[Dan Nicholson]

On Wed, Sep 22, 2010 at 2:01 PM, Trevor Woerner <twoerner at gmail.com> wrote:
> On Wed, Sep 22, 2010 at 11:54 AM, Gaetan Nadon <memsize at videotron.ca> wrote:
>> It would be nice to have reusable module list. I am trying to convince
>> Trevor about that.
>
> I'm concerned about your wording; I hope I haven't come across as
> being opposed to or resisting your ideas on this matter.
>
> With regards to the module list, my understanding is that there are two issues:
>
> 1. what is the complete list of possible modules I could build for a
> given platform (e.g. linux-i386)
> 2. can the user provide a list to the build script of just the modules
> they want to see built
>
> "build.sh -L" provides you with the answer to #1.

That's a nice feature, but it's hardcoded into the script and it only
operates on git master. If I want to add a module or use a particular
version, I've got to hack build.sh directly. It would be nicer if
build.sh could read a list of modules and just build those. Of course,
this is what jhbuild already does, and I'm not sure it's worth
reinventing the wheel.

The goal in my mind is that the module lists are maintained and
updated by the developers as Xorg changes and the build tools use
those lists.

> I have a patch to provide the functionality of #2, but I'm waiting to
> see what happens to the patch I provided a couple hours ago (perform
> arbitrary git or make commands) and the patch you provided to create
> subdirectories inside util/modular before submitting it. Additionally,
> the functionality of #2 uses the list of #1 to make sure the modules
> are built in the correct order irrespective of the order in which
> they're provided.
>
>> And if we were to have common module list, they perhaps should be in a
>> separate dir.
>
> The list of modules (and their order) inside the build.sh script isn't
> entirely static. It changes depending on which platform you are
> building for. So the list wouldn't be a static file, but rather would
> need some logic to be generated correctly. As I've said, "build.sh -L"
> provides you with this list.

You'd obviously have to keep some logic about platforms and
dependencies in build.sh, but hopefully there would only be a few
special cases for that. Anyway, it sounds like you have the
functionality for reading a module list worked out. The particulars
about where the list comes from or its format are mostly orthogonal.
Might as well post your patch.

--
Dan