patch: Xt-1.0.8 fix dereference

walter harms wharms at bfs.de
Wed Sep 22 09:21:38 PDT 2010


should i resend it ?
re,
 wh

Jeremy Huddleston schrieb:
> Hi wh,
> 
> Send patches like this to xorg-devel rather than the users list.
> 
> Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
> 
> On Sep 22, 2010, at 00:13, walter harms wrote:
> 
>> Hi List,
>> i found something that looked like a bug in libXt.
>> eventWidget->core.tm.proc_table is used before eventWidget is checked.
>>
>> this patch fixes that.
>> re,
>> wh
>>
>>
>>
>> --- libXt-1.0.8/src/TMprint.c.org       2010-09-21 23:42:08.000000000 +0200
>> +++ libXt-1.0.8/src/TMprint.c   2010-09-21 23:44:44.000000000 +0200
>> @@ -782,12 +782,16 @@
>>     PrintRec           stackPrints[STACKPRINTSIZE];
>>     PrintRec           *prints;
>>     TMShortCard                numPrints, maxPrints;
>> -    TMBindData bindData = (TMBindData) eventWidget->core.tm.proc_table;
>> +    TMBindData bindData ;
>>     TMComplexBindProcs complexBindProcs;
>>
>>     if ((eventWidget == NULL) ||
>> -       ((xlations = eventWidget->core.tm.translations) == NULL) ||
>> -       (bindData->simple.isComplex == False))
>> +       (eventWidget->core.tm.translations == NULL) )
>> +      return;
>> +
>> +    xlations = eventWidget->core.tm.translations;
>> +    bindData = (TMBindData) eventWidget->core.tm.proc_table;
>> +    if (bindData->simple.isComplex == False)
>>       return;
>>
>>     sb->current = sb->start = __XtMalloc((Cardinal)1000);
>> _______________________________________________
>> xorg at lists.freedesktop.org: X.Org support
>> Archives: http://lists.freedesktop.org/archives/xorg
>> Info: http://lists.freedesktop.org/mailman/listinfo/xorg
>> Your subscription address: jeremyhu at freedesktop.org
> 
> 


More information about the xorg-devel mailing list