[PATCH libpciaccess] config: provide a makefile for scanpci dev tool

Tiago Vignatti tiago.vignatti at nokia.com
Wed Sep 22 06:45:37 PDT 2010


On Tue, Sep 21, 2010 at 07:09:45PM +0200, ext Gaetan Nadon wrote:
> No function changes.
> 
> Note that automake generates a wrapper script if libpciaccess
> is not installed at configuration time, which is the most common case.
> 
> If it is installed at configuration time, you get an executable.
> 
> The makefile build order ensures the lib is build before scanpci.
> 
> The man page is moved to the man directory, as usual.
> 
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>

I think your changes are nice, but I'd prefer to see those split up in two
patches instead: one to remove the wrapper script, using a proper makefile and
another to move code around, creating scanpci/ directory and man/


Thank you,

        Tiago


More information about the xorg-devel mailing list