[PATCH build 01/10] Prettier failed component listing.

Trevor Woerner twoerner at gmail.com
Sat Sep 18 13:10:52 PDT 2010


From: Trevor Woerner <twoerner at gmail.com>

If there are components which don't exist, fail to build, or fail to clone
display them in a nicer format at the end of the build.

Signed-off-by: Trevor Woerner <twoerner at gmail.com>
---
 build.sh |   18 ++++++++++++------
 1 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/build.sh b/build.sh
index 10f716b..0636173 100755
--- a/build.sh
+++ b/build.sh
@@ -68,7 +68,7 @@ clonefailed_components=""
 failed() {
     if [ -n "${NOQUIT}" ]; then
 	echo "***** $1 failed on $2/$3"
-	failed_components="$failed_components $2/$3"
+	failed_components+="$2/$3 "
     else
 	exit 1
     fi
@@ -199,7 +199,7 @@ build() {
         clone $1 $2
         if [ $? -ne 0 ]; then
             echo "Failed to clone $1 module component $2. Ignoring."
-            clonefailed_components="$clonefailed_components $1/$2"
+            clonefailed_components+="$1/$2 "
             if [ -n "$BUILD_ONE" ]; then
                 exit 1
             fi
@@ -214,7 +214,7 @@ build() {
 
     if [ -z "$SRCDIR" ]; then
         echo "$1 module component $2 does not exist, skipping."
-        nonexistent_components="$nonexistent_components $1/$2"
+        nonexistent_components+="$1/$2 "
         return
     fi
 
@@ -879,21 +879,27 @@ date
 if [ -n "$nonexistent_components" ]; then
     echo ""
     echo "***** Skipped components (not available) *****"
-    echo "$nonexistent_components"
+    for _cmp in `echo $nonexistent_components`; do
+	echo -e "\t$_cmp"
+    done
     echo ""
 fi
 
 if [ -n "$failed_components" ]; then
     echo ""
     echo "***** Failed components *****"
-    echo "$failed_components"
+    for _cmp in `echo $failed_components`; do
+	echo -e "\t$_cmp"
+    done
     echo ""
 fi
 
 if [ -n "$CLONE" ] && [ -n "$clonefailed_components" ];  then
     echo ""
     echo "***** Components failed to clone *****"
-    echo "$clonefailed_components"
+    for _cmp in `echo $clonefailed_components`; do
+	echo -e "\t$_cmp"
+    done
     echo ""
 fi
 
-- 
1.7.3.rc2



More information about the xorg-devel mailing list