[PATCH build 3/3] Remove superfluous braces around variables.

Gaetan Nadon memsize at videotron.ca
Thu Sep 16 14:43:20 PDT 2010


On Wed, 2010-09-15 at 08:58 -0400, Trevor Woerner wrote:

> From: Trevor Woerner <twoerner at gmail.com>
> 
> Remove the '{' and '}' braces around variable dereferences
> which aren't necessary for shell parsing.
> 
> Signed-off-by: Trevor Woerner <twoerner at gmail.com>
> 


I much prefer when braces are not used when not required.
Most likely because that's what I see most often. A quick grep
on configure scripts in xorg shows a 15 to 1 ratio.

As I said on a previous post, the simple form (without braces) provide
information about the possible values the variable may or may not have.

Reviewed-by: Gaetan Nadon <memsize at videotron.ca>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100916/4933e99d/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100916/4933e99d/attachment.pgp>


More information about the xorg-devel mailing list