[PATCH build 3/3] Use consistent parameter expansion notation.

[Dan Nicholson]

On Wed, Sep 15, 2010 at 11:09 PM, Trevor Woerner <twoerner at gmail.com> wrote:
> From: Trevor Woerner <twoerner at gmail.com>
>
> Wrap bash parameter names in curly braces for expansion.
>
> Signed-off-by: Trevor Woerner <twoerner at gmail.com>
> ---
> So far 2 people have suggested they prefer seeing bash parameters consistently
> wrapped in curly braces and only 1 person has mentioned the preference to see
> the braces used only when necessary.
>
> Personally I have no preference. So I provide this patch as a corollary
> to my previous "Remove superfluous braces around variables" patch. People
> are welcome to comment and whichever proves to be more popular can be
> applied by those with commit access.

Clearly this is just bikeshedding, but I think this practice sucks.
There are very clear times when the braces are useful or needed to
delimit variables or do parameter expansion. Every other usage is just
adding extra characters and typing. This diff is a perfect example of
it: 114 lines changed for zero functional difference.

--
Dan