[PATCH build 2/2] Clean up all conditional statements.

[Tormod Volden]

On Wed, Sep 15, 2010 at 7:56 AM, Trevor Woerner wrote:
>
> -    if [ "$1" = "lib" ] && [ "$2" = "libX11" ] && [ x"$USE_XCB" = xNO ]; then
> +    if [ "$1" = "lib" ] && [ "$2" = "libX11" ] && [ "x${USE_XCB}" = "xNO" ]; then
>        MOD_SPECIFIC="--with-xcb=no"
>     fi

Any reason to not write just [ "$USE_XCB" = "NO" ] ? Then we could get
of all these x$checks, they are sooo 70's :)

>     ${MAKE} $MAKEFLAGS || failed make $1 $2

(and many other places)

For consistency, maybe get rid of unnecessary braces? Sometimes they
can make code more readable but most places here I think it is just
contamination from Makefile syntax.

Trevor, thanks for this initiative, it makes the code much nicer to read.

Tormod