[PATCH build] Make '['/'test' consistent.

Matt Dew matt at osource.org
Tue Sep 14 08:22:58 PDT 2010


On Tue, Sep 14, 2010 at 5:28 AM, Trevor Woerner <twoerner at gmail.com> wrote:
> On Tue, Sep 14, 2010 at 1:51 AM, Jeremy Huddleston <jeremyhu at apple.com> wrote:
>> I personally prefer [ ] over test ...
>
> That's funny... so do I. When I first added the lines to support the
> '-L' option I used '[]'. It had been suggested, however, that it would
> be nice if the whole file used one or the other consistently and since
> there were 30 lines using 'test' and only 14 using '[]' I assumed
> 'test' was the preferred.

I second the consistency comment. As long as it's consistent
everywhere, use whatever.

Matt


More information about the xorg-devel mailing list