[PATCH app-xdm 15/19] config: definition of CSRG_BASED in configure.ac is flawed and redundant

Mark Kettenis mark.kettenis at xs4all.nl
Thu Sep 9 06:36:09 PDT 2010


> From: Gaetan Nadon <memsize at videotron.ca>
> Date: Thu, 09 Sep 2010 09:05:17 -0400
> 
> CSRG_BASED is defined in both the xserver using platform checks
> and in Xosdefs.h using compiler macros.
> 
> The one from X11/Xosdefs.h will be used through already included headers:
> # if defined(__OpenBSD__) || defined(__NetBSD__) || defined(__FreeBSD__) \
> 	|| defined(__APPLE__) || defined(__DragonFly__)
> #  ifndef CSRG_BASED
> #   define CSRG_BASED
> #  endif
> # endif
> 
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>

Reviewed-by: Mark Kettenis <kettenis at openbsd.org>

> ---
>  configure.ac |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index a2ba334..ac7e828 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -160,7 +160,7 @@ case $host_os in
>  	SU="su -m"
>          ;;
>      *bsd*|dragonfly*)
> -        OS_CFLAGS="-DCSRG_BASED"
> +        OS_CFLAGS=""
>  	SU="su -m"
>          ;;
>      solaris*|sysv4*)
> -- 
> 1.6.0.4


More information about the xorg-devel mailing list