[PATCH] composite: only update window contents when using automatic redirection

Adam Jackson ajax at nwnk.net
Wed Sep 8 08:40:51 PDT 2010


On Tue, 2010-09-07 at 14:43 -0700, Keith Packard wrote:
> On Tue, 7 Sep 2010 12:48:32 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> 
> > Brian pointed this out awhile back but the fix was never merged.  So
> > here's a real patch.  Would be nice to get into 1.9.x as well if it
> > proves ok in master.
> 
> Looks like there are additional optimizations available here -- we're
> doing a full tree traversal per block handler whenever anything is
> damaged. Can the 'damage' boolean in both screen and window be
> restricted to Automatic update mode?

cs->damaged would need to be set for any automatic updates on the
screen, but otherwise I think the answer is yes.

Is there a reason why compWindowUpdate isn't a call to TraverseTree?  I
always feel nervous when I see manual tree walks, particularly when
TraverseTree tries so hard to not be recursive.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100908/ffb7691c/attachment.pgp>


More information about the xorg-devel mailing list