[PATCH 12/19] xfree86: update comment for xf86DeleteInput

Fernando Carrijo fcarrijo.lists at gmail.com
Tue Sep 7 19:05:24 PDT 2010


Peter Hutterer <peter.hutterer at who-t.net> wrote:

> We have a driver hook - it's UnInit.
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Reviewed-by: Fernando Carrijo <fcarrijo at freedesktop.org>

> ---
>  hw/xfree86/common/xf86Xinput.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/xfree86/common/xf86Xinput.c b/hw/xfree86/common/xf86Xinput.c
> index e0211d9..39ea883 100644
> --- a/hw/xfree86/common/xf86Xinput.c
> +++ b/hw/xfree86/common/xf86Xinput.c
> @@ -679,10 +679,8 @@ xf86AddInput(InputDriverPtr drv, InputInfoPtr pInfo)
>  }
>  
>  /*
> - * Remove an entry from xf86InputDevs.  Ideally it should free all allocated
> - * data.  To do this properly may require a driver hook.
> + * Remove an entry from xf86InputDevs and free all the device's information.
>   */
> -
>  void
>  xf86DeleteInput(InputInfoPtr pInp, int flags)
>  {

By the way, the parameter flags is unused in this function.

An orthogoal concern with respect to your series, for sure.

> -- 
> 1.7.2.2
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel


More information about the xorg-devel mailing list