[PATCH 3/4] xfree86: fbdevhw: remove superfluous pci pointer from probe function

[Mark Kettenis]

> From: Tiago Vignatti <tiago.vignatti at nokia.com>
> Date: Tue,  7 Sep 2010 15:18:48 +0300
> 
> The only drivers using this function are fbdev and glint. Though those driver
> initialize with NULL argument. Other drivers do some kind of implicit probe
> using fbdevHWInit instead.
> 
> API break.

Sorry, but I really fail to see the purpose of this change.  It is
true that the only open source driver that actually uses
fbdevHWProbe() passes NULL as the first argument, but as far as I can
tell, calling it with a non-NULL first argument is not unreasonable.
Your diff destroys the symmetry between fbdevHWProbe() and
fbdevHWInit().

That said, the glint driver only calls fbdevHWProbe() inside a #ifndev
XSERVER_LIBPCIACCESS block.  The comment says this is "for systems
without (proper) PCI support".  So perhaps this code has outlived its
usefulness, and fbdevHWProbe() should be removed altogether?