[PATCH libXext] sync declarations/definitions of xgeExtRegister()

Alan Coopersmith alan.coopersmith at oracle.com
Tue Sep 7 13:31:20 PDT 2010


Shouldn't this just go into an internal .h instead of trying to keep definitions
in sync between multiple *.c files?

	-alan-

Rémi Cardona wrote:
> src/extutil.c has _X_HIDDEN while src/Xge.c didn't. This apparently went
> unnoticed by most compilers for a while, but not on Gentoo-prefix/amd64
> where this issue breaks the build.
> 
> Fixes https://bugs.freedesktop.org/show_bug.cgi?id=29958
> 
> Signed-off-by: Ivan Jager <aij+freedesktop.org at mrph.org>
> Reviewed-by: Rémi Cardona <remi at gentoo.org>
> ---
> 
> Could I get an extra pair of eyes to ACK this before committing?
> 
> Thanks,
> 
> Rémi
> 
>  src/Xge.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/Xge.c b/src/Xge.c
> index 0655e00..2e25894 100644
> --- a/src/Xge.c
> +++ b/src/Xge.c
> @@ -291,7 +291,7 @@ _xgeEventToWire(Display* dpy, XEvent* re, xEvent* event)
>  /*
>   * Extensions need to register callbacks for their events.
>   */
> -Bool
> +_X_HIDDEN Bool
>  xgeExtRegister(Display* dpy, int offset, XExtensionHooks* callbacks)
>  {
>      XGEExtNode* newExt;


-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list