[PATCH v2] xfree86: remove IDevRec, replace with InputInfoRec.

Vignatti Tiago (Nokia-MS/Helsinki) tiago.vignatti at nokia.com
Tue Sep 7 05:20:00 PDT 2010


On Tue, Sep 07, 2010 at 01:42:47AM +0200, ext Peter Hutterer wrote:
> This struct is superfluous, maintaining the same info as the InputInfoRec
> (with the exception of the driver name).
> 
> This is a rather large commit with the majority of changes being a rename
> from the fields of the IDevRec (idev, commonOptions) to the InputInfoRec
> (pInfo, options).
> 
> The actual changes affect the initialization process of the input device:
> In NewInputDeviceRequest, the InputInfoRec is now always allocated and just
> added to the internal list in xf86NewInputDevice() if the init process
> succeeded.
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
> Changes to v1:
> - Patches 14/19 and 19/19 squashed in.
> - InputInfoPtr typedef sanitized slightly (see hunk in xf86Xinput.h).
> 
> Tiago, the typedef changes because we need it the InputInfoRec in xf86str.h.
> It's not ideal but slightly better than the previous one, imo.

Reviewed-by: Tiago Vignatti <tiago.vignatti at nokia.com>

             Tiago


More information about the xorg-devel mailing list