[PATCH 00/19] input API cleanup round 2

[Tiago Vignatti]

On Mon, Sep 06, 2010 at 04:52:36AM +0200, ext Peter Hutterer wrote:
> 
> This is the second lot of input API cleanups and it goes on top of the
> patches already reviewed earlier. The full branch is available in my
> people.fdo directory.
> 
> Most notable here is the removal of the IDevRec struct which seemed somewhat
> superfluous. Most of the rest is minor cleanup, some could be cherry-picked
> straight to master (but conflicts made that too hard to bother).

that's great!

Seems we have only Input handler proc now inside xf86str.h which is related
with input stuff. This is addressed by Fernando's patch sent last week -
which, btw, we need review on those to post next version of input thread's
series again. So please :)

Then we can rename xf86str.h to probably xf86Xvideo.h and remove the header
from being included by input drivers (indirectly being called by xf86.h).
Actually, we have to rework quite a lot these headers (for instance not adding
xf86Priv.h and xf86Privstr.h on our SDK).


> Peter Hutterer (19):
>       input: constify valuators passed in by input drivers.
>       Remove atom field from InputInfoRec.
>       xfree86: remove conversion procs and close proc from InputInfoRec.
>       xfree86: skip a few NULL initialization, calloc does it for us.
>       xfree86: minor comment fix. HAL → config backend
>       xfree86: move a declaration down to the block it is used in.
>       xfree86: remove some ifdef 0 code.
>       xfree86: remove extraOptions field from IDevRec.
>       xfree86: Remove extraOptions parameter from xf86CollectInputOptions.
>       xfree86: plug minor memory leak.
>       xfree86: remove IDevRec, replace with InputInfoRec.
>       xfree86: update comment for xf86DeleteInput
>       xfree86: remove XI_PRIVATE macro, unused.
>       xfree86: remove superfluous decl of InputInfoRec.
>       xfree86: don't export xf86InputDevs.
>       xfree86: remove {Dont}SendCoreEvents defines
>       xfree86: remove TS_Raw and TS_Scaled defines.
>       xfree86: move XI_VERIFY_VALUATORS to the source file it's used in.
>       xfree86: only call UnInit if the driver was set.

Besides some nitpicking I pointed, your changes are nice for me:

    Reviewed-by: Tiago Vignatti <tiago.vignatti at nokia.com>


Cheers,
             Tiago