[PATCH] exa/mixed: avoid unnecessary dest system buffer copy in prepare_access_reg

[Michel Dänzer]

On Mon, 2010-09-06 at 14:58 +1200, xmail at karlt.net wrote: 
> On Fri, 03 Sep 2010 09:57:37 +0200, Michel Dänzer wrote:
> 
> > On Don, 2010-08-26 at 22:57 +1200, Karl Tomlinson wrote: 
> >> 
> >> A region is only provided to prepare_access_reg for destination pixmaps when
> >> the operator will not read from the destination.  A non-NULL region therefore
> >> indicates that no pixels in the destination gpu buffer need to be copied to
> >> the system buffer.
> >> 
> >> The provided region still serves a purpose, as it indicates the portion of
> >> the system buffer that will be damaged.
> >> ---
> >>  exa/exa_migration_mixed.c |   42 ++++++++++++++++++++++++++++--------------
> >>  1 files changed, 28 insertions(+), 14 deletions(-)
> >
> > I like the idea of this[0], but unfortunately it breaks the transparency
> > of rounded window corners with compiz here, see the attached screenshot.
> > Are you seeing this as well?
> 
> I haven't been able to reproduce this problem.  Here rounded
> corners seem fine with emerald, gtk-, or kde4- window-decorator.

Hrm. FWIW I'm using gtk-window-decorator from the Debian compiz 0.8.4-4
packages, with the Clearlooks theme for window borders.


> I've been testing with xserver 1.8.2.  Not much has changed in
> EXA, but I guess other changes could possibly be involved.

Right, none of the changes seem immediately relevant but I am running
Git master.


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer