[PATCH app-xdm 00/23] Review xdm configuration - Part 2

[Alan Coopersmith]

Gaetan Nadon wrote:
> Mostly platform checks, defines and functions

I can't speak for the other platforms, but it builds fine on Solaris
with the Sun compilers,  and I don't see anything I'd object to. I'd
like to hear if the people building for those platforms see any problems.

A few comments:

> This would be used to support lasltlog as sessreg does,
> however no code makes use of it.
> A code search shows that this is a macro only defined in app/sessreg.

sessreg was part of xdm until commit 6ae3766444c62ee, when it was broken
out so other display managers like gdm could use it without having to
install all of xdm, so that would be an accidental leftover.  (BTW, typo
in the comment, you have an extra "l" in lastlog.)

> [PATCH app-xdm 22/23] config: use AC_CHECK_FUNCS for mkstemp,	getifaddrs ans getspnam

Typo: ans -> and

> AC_CHECK_FUNCS adds an AC_DEFINE of HAVE_XXX in addition of checking
> for the functions. It has a consistent naming convention.

The "HAS_*" names were used in the imake definitions and left that way
during the transition period.   Once the X11R7.0 release was done and we
no longer needed to support imake, they no longer needed to be different
from the autoconf default names, but we never cleaned them up.
Thanks for picking up after us.

BTW, this check fails to find getifaddrs() on Solaris releases that have it:
> +AC_CHECK_FUNCS(mkstemp getifaddrs getspnam)

You need to move the XTRANS_CONNECTION_FLAGS before it so that the required
libraries for the sockets API are already in $LIBS.

Not finding getifaddrs() doesn't break anything, just causes it to use the
ioctls found on previous Solaris releases, which still work fine.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System