[PATCH 1/2] Replace usage of DamageRegionAppend with DamageDamageRegion to fix reportAfter.

Michel Dänzer michel at daenzer.net
Sun Oct 31 04:07:33 PDT 2010


On Sam, 2010-10-30 at 12:36 -0700, Keith Packard wrote: 
> On Sat, 30 Oct 2010 18:07:19 +0200, Michel Dänzer <michel at daenzer.net> wrote:
> 
> > Right, but as long as there's at least one rendering operation in
> > between, at that point EXA will synchronize the pixmap copies according
> > to the accumulated pending damage. That's the assumption broken by your
> > change.
> 
> Eric's patch just catches a few non-rendering paths where post-op damage
> would not generate Damage events, as DamageRegionProcessPending would
> never have been invoked. For all rendering paths, it changes nothing [...]

I know, as I said, the problem is when there's *no* rendering operation
between DamageRegionAppend and DamageRegionProcessPending. (IIRC the
problem I mentioned with starting compiz from a naked xterm was due to
ProcDamageCreate called by compiz)


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer


More information about the xorg-devel mailing list