displayid: dubious assignments
Nicolas Kaiser
nikai at nikai.net
Sat Oct 30 12:03:49 PDT 2010
Hi there!
I noticed two assignments that look a bit peculiar to me.
n is assigned MAX_HSYNC and MAX_VREFRESH, but these values
get either overwritten or remain unused.
I hope that's not a problem?
hw/xfree86/modes/xf86DisplayIDModes.c +318
n = mon->nHsync++;
if (n < MAX_HSYNC) {
mon->hsync[n].lo = x[9];
mon->hsync[n].hi = x[10];
} else {
-> n = MAX_HSYNC;
}
-> n = mon->nVrefresh++;
if (n < MAX_VREFRESH) {
mon->vrefresh[n].lo = x[13];
mon->vrefresh[n].hi = x[14];
} else {
-> n = MAX_VREFRESH;
}
-> break;
Best regards,
Nicolas Kaiser
More information about the xorg-devel
mailing list