[PATCH libXt] Fix possible NULL access

walter harms wharms at bfs.de
Wed Oct 27 05:24:35 PDT 2010



Matthieu Herrb schrieb:
> On Tue, Oct 26, 2010 at 02:00:09PM +0200, walter harms wrote:
>> +	      // value.addr can be NULL see: !already_copied
>> +	      if (value.addr)
>>  		*((XtTranslations *)&widget->core.tm.current_state) =
>>  		    *((XtTranslations *)value.addr);
> 
> Sorry to only have lame comments, but this is C not C++. Use C style
> comments please (/* */) here.
> 

mmh if i remember correctly they are available since C99,
NTL that can be changed very easy, is it custon in X11 to have /* */ comments ?

re,
 wh


More information about the xorg-devel mailing list