[PATCH] mi: Integer overflow for dashed lines longer than 46340. #31093

Keith Packard keithp at keithp.com
Mon Oct 25 12:37:46 PDT 2010


On Mon, 25 Oct 2010 11:51:46 +0530, Siddhesh Poyarekar <siddhesh.poyarekar at gmail.com> wrote:

> -    if (slopes[j].dy * slopes[i].dx > slopes[i].dy * slopes[j].dx)
> +    if ((long long)slopes[j].dy * slopes[i].dx > (long long)slopes[i].dy * slopes[j].dx)

Looks like the fix is in the right place, but I'd prefer int64_t instead of 'long long' here.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101025/220263d7/attachment.pgp>


More information about the xorg-devel mailing list