[PATCH libXi] Force class alignment to a multiple of sizeof(XID).

Julien Cristau jcristau at debian.org
Sat Oct 23 04:08:44 PDT 2010


On Mon, Oct 18, 2010 at 10:51:09 +1000, Peter Hutterer wrote:

> Calculate length field to a multiples of sizeof(XID). XIDs are typedefs
> to ulong and thus may be 8 bytes on some platforms. This can trigger a
> SIGBUS if a class ends up not being 8-aligned (e.g. after XAxisInfo).
> 
> Reported-by: Nicolai Stange <nicolai.stange at zmaw.de>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
> 
> > That would break ABI, though, so we can't do that...  I think we should
> > make sure the length field of a XAnyClassInfo is a multiple of
> > sizeof(XID).
> 
> something like this?
> 
SizeClassInfo() looks like it needs these changes as well?

Cheers,
Julien


More information about the xorg-devel mailing list