[PATCH] Revert "Set DamageSetReportAfterOp to true for the damage extension" (#30260)

Aaron Plattner aplattner at nvidia.com
Wed Oct 20 15:10:01 PDT 2010


On Wed, Oct 20, 2010 at 03:03:59PM -0700, Aaron Plattner wrote:
> On Wed, Oct 20, 2010 at 02:57:27PM -0700, Keith Packard wrote:
> > On Wed, 20 Oct 2010 14:29:33 -0700, Aaron Plattner <aplattner at nvidia.com> wrote:
> > > The driver can do that by enabling ReportAfter from a damage create
> > > hook.
> > 
> > No, it must see the rendering request before the damage extension writes
> > the damage event to the client, hence the damage extension itself must
> > pend the delivery of this event until after the rendering operation has
> > been delivered to the client.
> 
> ... for your driver, and only until we have a sync extension.

Oh wait, I'm confused... I was talking about making the drivers that need
this wrap DamageCreate or DamageRegister and enable ReportAfterOp there so
that they get the same semantics without baking that behavior into the
server for all drivers.  The drivers that opt into that behavior will still
see the rendering before the event is generated... I'm not talking about
disabling this behavior permanently for everbody, just reverting it out of
the server proper.


More information about the xorg-devel mailing list