[PATCH xf86-input-vmmouse 1/2] Deprecated code cleanup.

Thomas Hellstrom thellstrom at vmware.com
Tue Oct 19 10:09:39 PDT 2010


On 10/19/2010 04:13 PM, Trevor Woerner wrote:
> On Tue, Oct 19, 2010 at 9:00 AM, Thomas Hellstrom<thellstrom at vmware.com>  wrote:
>    
>> On 10/19/2010 02:50 PM, Trevor Woerner wrote:
>> Instead of defining a HAVE_XORG_SERVER_1_5_0 flag at
>> configure time, IMO it's also OK to define such a flag during compile time
>> using the macros XORG_VERSION_CURRENT and XORG_VERSION_NUMERIC
>>      
> I'm unfamiliar with this project (from a code point of view), so to me
> both options are the same. Is there any advantage to doing it one way
> over the other? Would you prefer to see it done as you've described
> here, or as was done in the vmware patch?
>
> Best regards,
>      Trevor
>    
Hi, Trevor.

Please use the same way as in the vmware patch for now. At some point in 
the futurem I might go over both drivers and change it to the 
XORG_VERSION macros, since it makes it easier to build the driver on 
systems that don't have pkgconfig.

Thanks,

/Thomas



More information about the xorg-devel mailing list