[PATCH] Use external tool for creating backtraces on crashes if available.

[Keith Packard]

On Fri,  8 Oct 2010 18:25:12 +0200, Matthias Hopf <mhopf at suse.de> wrote:

> +    if (! (f = fdopen (fd, "r"))) {
> +	ErrorF ("xorg_backtrace_gdb internal error 2\n");
> +	close (fd);
> +	return 1;
> +    }
> +    status = 0;
> +    while (fgets (buf, 256, f)) {
> +	status++;
> +	ErrorF("%s", buf);
> +    }
> +    fclose (f);

I'd think you'd want to avoid anything that might allocate memory in
this code; a rather common crash cause is smashing malloc data.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101019/16d1fb4d/attachment.pgp>