[PATCH 1/9] render: warning fixes

Keith Packard keithp at keithp.com
Tue Oct 19 09:15:44 PDT 2010


>      /* protect against bad nglyphs */
> -    if (gi < stuff || gi > ((CARD32 *)stuff + client->req_len) ||
> -        bits < stuff || bits > ((CARD32 *)stuff + client->req_len)) {
> +    if ((void *)gi < (void *)stuff ||
> +	(void *)gi > (void *)((CARD32 *)stuff + client->req_len) ||
> +        (void *)bits < (void *)stuff ||
> +	(void *)bits > (void *)((CARD32 *)stuff + client->req_len)) {

I'm not entirely sure if (void *) is an ordered pointer type, or if we
should be casting these to (char *) instead?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101019/22d5918c/attachment.pgp>


More information about the xorg-devel mailing list