[PATCH xf86-input-keyboard 2/2] Code cleanup, structure initialization.

Peter Hutterer peter.hutterer at who-t.net
Mon Oct 18 16:07:07 PDT 2010


On Mon, Oct 18, 2010 at 01:24:34PM -0400, Gaetan Nadon wrote:
> On Mon, 2010-10-18 at 11:38 -0400, Trevor Woerner wrote:
> 
> > The InputDriverRec data structure in
> > xserver/hw/xfree86/common/xf86Xinput.h
> > no longer contains an integer refCount member.
> > 
> 
> Have you taken into account that this driver still builds with server
> 1.3 or later?
> 
>         PKG_CHECK_MODULES(XORG, [xorg-server >= 1.2.99.0] xproto inputproto)
> 
> I am not familiar with the details of how that works, but I see lines
> like this in the code:
> 
>         #if GET_ABI_MAJOR(ABI_XINPUT_VERSION) < 1
> 

I just searched through the git history for any mentions of refCount usage 
- without success. I think we can safely apply this patch.

Cheers,
  Peter


More information about the xorg-devel mailing list