[PATCH] Skip unnecessary operations when moving a manually redirected window

Keith Packard keithp at keithp.com
Mon Oct 18 12:39:01 PDT 2010


On Sun, 17 Oct 2010 19:53:50 +0200, Adel Gadllah <adel.gadllah at gmail.com> wrote:

> +#ifdef COMPOSITE
> +    /*
> +     * Manually redirected windows don't affect the parent's clip
> +     * region, so skip the unnecessary and possible expensive
> +     * operations
> +     */
> +    if (pWin->redirectDraw == RedirectDrawManual)
> +        WasViewable = FALSE;
> +#endif
> +

You still have to update the sub-tree clip lists to account for the new
absolute position.

As discussed on IRC, I think there is an opportunity to improve
ValidateTree performance for manual redirect window trees by avoiding
marking sibling windows in miMarkOverlappedWindows and then by noticing
when all marked windows are manual redirect in miValidateTree.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101018/ce851822/attachment.pgp>


More information about the xorg-devel mailing list