[PATCH xf86-input-keyboard 2/2] Code cleanup, structure initialization.

[Trevor Woerner]

On Mon, Oct 18, 2010 at 1:24 PM, Gaetan Nadon <memsize at videotron.ca> wrote:
> On Mon, 2010-10-18 at 11:38 -0400, Trevor Woerner wrote:
>> The InputDriverRec data structure in xserver/hw/xfree86/common/xf86Xinput.h
>> no longer contains an integer refCount member.
>
> Have you taken into account that this driver still builds with server 1.3 or
> later?
>
> PKG_CHECK_MODULES(XORG, [xorg-server >= 1.2.99.0] xproto inputproto)
>
> I am not familiar with the details of how that works, but I see lines
> like this in the code:
>
> #if GET_ABI_MAJOR(ABI_XINPUT_VERSION) < 1

Unfortunately not; I don't have any understanding of how the
versioning works with regards to building newer drivers for older
servers, or visa-versa, or whatever it is this versioning stuff is
trying to accomplish.

I'd appreciate a lesson (or a link to a description) so I can clean up
this code properly.