[PATCH 1/3] os/xfree86: remove macro checking for POSIX symbols

[Guillem Jover]

Hi!

On Thu, 2010-09-09 at 11:01:48 +0300, Vignatti Tiago (Nokia-MS/Helsinki) wrote:
> On Wed, Sep 08, 2010 at 03:14:12AM +0200, ext Guillem Jover wrote:
> > On Tue, 2010-09-07 at 15:39:17 +0300, Tiago Vignatti wrote:
> > > We assume already that our X implementation is POSIX compliant anyway. So
> > > remove those redundant checking.
> > 
> > Well POSIX-1.2001, some of these are still XSI extensions, namely
> > SIGSYS, SIGVTALRM, SIGXCPU, SIGXFSZ (which only switched to mandatory
> > in POSIX-1.2008).
> 
> ouch, good catch. Anyway, I'm pretty sure we're going to start a long
> discussion if we try to set a base POSIX for X right now...

See my reply to Alan, it seems to me that's already set, which is why
I replied to your patch.

> > In addition to what Olaf has said, SA_SIGINFO is also XSI optional, and
> > I think other systems besides the Hurd lack implementation.
> 
> So if we keep SA_SIGINFO out of that patch then do you think is enough to
> cover all current OSs we are running X?

Well I don't think it's a good idea to expect POSIX-1.2008 in this
point in time. I also didn't see the harm in leaving some other ifdefs
there. But anyway I see this has been applied now, if it does not work
somewhere, people can just complain.

regards,
guillem