[PATCH] event_size is currently never assigned to in mieqProcessInputEvents().

Jon TURNEY jon.turney at dronecode.org.uk
Wed Oct 13 08:07:08 PDT 2010


On 22/02/2010 14:29, Jon TURNEY wrote:
> event_size is never assigned to in mieqProcessInputEvents(), so xrealloc()
> is always called.  This is benign, but I'm guessing not intended.
>
> Signed-off-by: Jon TURNEY<jon.turney-GrJqePx9RPPAJUdA+FbntA at public.gmane.org>
> ---
>   mi/mieq.c |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/mi/mieq.c b/mi/mieq.c
> index 9b6d0c9..1122bf4 100644
> --- a/mi/mieq.c
> +++ b/mi/mieq.c
> @@ -439,7 +439,10 @@ mieqProcessInputEvents(void)
>
>           evlen   = e->events->evlen;
>           if(evlen>  event_size)
> +          {
>               event = xrealloc(event, evlen);
> +            event_size = evlen;
> +          }
>
>           if (!event)
>               FatalError("[mi] No memory left for event processing.\n");

Ping?


More information about the xorg-devel mailing list