[PATCH 09/18] Avoid bogus coord reporting with clickpad devices

Takashi Iwai tiwai at suse.de
Tue Oct 12 23:05:37 PDT 2010


At Wed, 13 Oct 2010 13:24:53 +1000,
Peter Hutterer wrote:
> 
> On Fri, Oct 08, 2010 at 07:22:33PM +0200, Takashi Iwai wrote:
> > When a clickpad device without multi-touch kernel support is used,
> > it gives wrong positions and leads to the annoying pointer jumps.
> > Filter the bogus events out in such a case.
> 
> if the events are really bogus, why doesn't the kernel driver filter them?
> 
> if they're not bogus but valid finger data, I need some more information on
> what exactly happens, because this is a bit... odd.
> We have a number of devices that send events outside the min/max range and
> need to handle those, so I'm not sure this approach is the best.

This is a workaround for clickpad dragging working even in ST mode,
thus it becomes obsoleted when MT is enabled.

AFAIK, these strange packets are sent only in ST mode.  It looks like
the device sends another data (maybe no bogus but differently encoded)
for multi-touch.

I kept this patch in my series just for making the driver working even
with unmodified kernel in ST mode.  We can drop it, basically.


thanks,

Takashi


More information about the xorg-devel mailing list