[PATCH 0/2] Synaptics absolute coordinate motion event support

[Peter Hutterer]

On Mon, Oct 11, 2010 at 09:11:51PM -0400, Joe Shaw wrote:
> Hi,
> 
> On Mon, Oct 11, 2010 at 9:06 PM, Peter Hutterer
> <peter.hutterer at who-t.net> wrote:
> > On Mon, Oct 11, 2010 at 12:39:03PM -0400, Joe Shaw wrote:
> >> Indeed, I doubt many, but these patches aren't academic.  I'm working
> >> on a product which does use a touchpad in absolute mode.
> >
> > do you use the synaptics features (two-finger scrolling, tapping, etc.)?
> > if not, evdev may be the better choice.
> 
> For better or for worse, yes.
> 
> >> > either way, with these patches the cursor jumps back to 0/screen height
> >> > because the last four events sent by the device after releasing are
> >> > xmin/ymax, resetting the cursor. Something's not quite right there, can you
> >> > please check this again? thanks.
> >>
> >> I saw something like this too on my device, but since we're also
> >> working on the hardware I just fixed the firmware to not send an X,Y
> >> of 0,0 when BTN_TOUCH is 0.
> >>
> >> Do you see the xmin/ymax issue with evtest as well, or only through
> >> "xinput test"?
> >
> > yes, I get x 0 and y <max> values in the same event that sets BTN_TOUCH
> > to 0. which indicates a bug in the synaptics driver, we should just ignore
> > that packet then.
> 
> Ok, I will take a look at fixing that as well.  I think there is some
> similar code to deal with that in the evdev driver.
> 
> Other than that, do you see any issues with the patches as written?

no, the rest is fine. (I was about to push the patches when I noticed the
jump :)
 
Cheers,
  Peter