[PATCH] xace: micro-optimize callbacks

Alan Coopersmith alan.coopersmith at oracle.com
Mon Oct 11 13:20:42 PDT 2010


Keith Packard wrote:
> On Mon, 11 Oct 2010 11:16:54 -0400, Adam Jackson <ajax at redhat.com> wrote:
> 
>> +#define CallCallbacks(x, y) \
>> +    if ((*(x))) CallCallbacks(x, y);
>> +
> 
> I know the patch is cute like this, but it seems like simply making
> CallCallbacks an inline function would be cleaner.

CallCallbacks is just one more check than the above, so the only downside
I see is that _CallCallbacks then has to go from a static function to
becoming an exported part of the ABI.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list