[PATCH xrdb] Get rid of PATHETICCPP macro

Mikhail Gusarov dottedmag at dottedmag.net
Sun Oct 10 11:57:08 PDT 2010


Twas brillig at 21:47:05 10.10.2010 UTC+03 when bunk at stusta.de did gyre and gimble:

 >> This macro was undefined since 7.0. Generated by unifdef -UPATHETICCPP

 AB> Please also manually check the changed code.

Well, I did.

 >>...
 >>      if (!filename &&
 >> -#ifdef PATHETICCPP
 >> -        need_real_defines
 >> -#else
 >>          (oper == OPLOAD || oper == OPMERGE || oper == OPOVERRIDE) &&
 >>          (whichResources == RALL || whichResources == RSCREENS)
 >> -#endif
 >>          ) {
 >>...

 AB> Technically the result is correct, but the resulting code looks 
 AB> weird and should be properly formatted.

I can't think of another way to format this if clause.

-- 
  http://fossarchy.blogspot.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101010/8d8d1e17/attachment.pgp>


More information about the xorg-devel mailing list