[PATCH] xfree86: Fix regression from ab7f057 on LoaderOpen failure

Chris Wilson chris at chris-wilson.co.uk
Fri Oct 8 08:49:59 PDT 2010


In ab7f057 LoaderOpen was changed to return a NULL pointer instead of -1
in case of failure. However, one callsite was overlooked during the
conversion.

Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Adam Jackson <ajax at redhat.com>
---
 hw/xfree86/loader/loadmod.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/xfree86/loader/loadmod.c b/hw/xfree86/loader/loadmod.c
index 6e65227..9c04f6b 100644
--- a/hw/xfree86/loader/loadmod.c
+++ b/hw/xfree86/loader/loadmod.c
@@ -920,7 +920,7 @@ doLoadModule(const char *module, const char *path, const char **subdirlist,
 	goto LoadModule_fail;
     }
     ret->handle = LoaderOpen(found, errmaj, errmin);
-    if (ret->handle < 0)
+    if (!ret->handle)
 	goto LoadModule_fail;
     ret->path = strdup(found);
 
-- 
1.7.1



More information about the xorg-devel mailing list